Bug 181591 - WebProcess should pass the registration identifier and not the worker identifier for fetch events
Summary: WebProcess should pass the registration identifier and not the worker identif...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-12 06:48 PST by youenn fablet
Modified: 2018-01-12 11:44 PST (History)
6 users (show)

See Also:

Attachments
Patch (27.72 KB, patch)
2018-01-12 06:55 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-01-12 06:48:06 PST 
Currently, the web process is passing a service worker identifier.
But the storage process may actually make this service worker redundant if updating it.
In such a case the WebProcess active service worker
This happens for instance when a service worker that does not control any client yet is being updated and shortly after a client is starting to be controlled.

Registration identifier stays valid so it is best to use that one instead and compute the serviceWorkerIdentifier in the StorageProcess.
Comment 1 youenn fablet 2018-01-12 06:55:28 PST 
Created attachment 331199 [details]
Patch
Comment 2 WebKit Commit Bot 2018-01-12 11:43:40 PST 
Comment on attachment 331199 [details]
Patch

Clearing flags on attachment: 331199

Committed r226904: <https://trac.webkit.org/changeset/226904>
Comment 3 WebKit Commit Bot 2018-01-12 11:43:42 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-01-12 11:44:18 PST 
<rdar://problem/36477786>