WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
181562
Each variant of a polymorphic inlined call should be exitOK at the top of the block
https://bugs.webkit.org/show_bug.cgi?id=181562
Summary
Each variant of a polymorphic inlined call should be exitOK at the top of the...
Saam Barati
Reported
2018-01-11 15:40:44 PST
Right now, the very first block in the switch will have exitOK at the top. Others won't. That's just a bug. They're all exitOK at the top. This will lead to crashes in FixupPhase because we won't have a node in a block that has ExitOK, so when we fixup various type checks, we assert out.
Attachments
patch
(3.05 KB, patch)
2018-01-11 16:37 PST
,
Saam Barati
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2018-01-11 15:42:51 PST
<
rdar://problem/36445624
>
Saam Barati
Comment 2
2018-01-11 16:37:41 PST
Created
attachment 331139
[details]
patch
Yusuke Suzuki
Comment 3
2018-01-12 00:07:37 PST
Comment on
attachment 331139
[details]
patch r=me
WebKit Commit Bot
Comment 4
2018-01-12 02:15:15 PST
Comment on
attachment 331139
[details]
patch Clearing flags on attachment: 331139 Committed
r226881
: <
https://trac.webkit.org/changeset/226881
>
WebKit Commit Bot
Comment 5
2018-01-12 02:15:16 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug