Bug 181508 - Our for-in caching is wrong when we add indexed properties on things in the prototype chain
Summary: Our for-in caching is wrong when we add indexed properties on things in the p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-10 17:24 PST by Saam Barati
Modified: 2018-01-11 00:18 PST (History)
13 users (show)

See Also:

Attachments
patch (5.38 KB, patch)
2018-01-10 17:49 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2018-01-10 17:24:23 PST 
I was reading the for-in code looking for Speedometer speedups, and the code is clearly wrong when it comes to indexed properties in the prototype chain. Fix should be trivial.
Comment 1 Saam Barati 2018-01-10 17:49:14 PST 
Created attachment 330999 [details]
patch
Comment 2 Yusuke Suzuki 2018-01-10 18:15:15 PST 
Comment on attachment 330999 [details]
patch

r=me, nice catch.
Comment 3 WebKit Commit Bot 2018-01-11 00:16:11 PST 
Comment on attachment 330999 [details]
patch

Clearing flags on attachment: 330999

Committed r226767: <https://trac.webkit.org/changeset/226767>
Comment 4 WebKit Commit Bot 2018-01-11 00:16:13 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-01-11 00:18:33 PST 
<rdar://problem/36430219>