WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
181508
Our for-in caching is wrong when we add indexed properties on things in the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=181508
Summary
Our for-in caching is wrong when we add indexed properties on things in the p...
Saam Barati
Reported
2018-01-10 17:24:23 PST
I was reading the for-in code looking for Speedometer speedups, and the code is clearly wrong when it comes to indexed properties in the prototype chain. Fix should be trivial.
Attachments
patch
(5.38 KB, patch)
2018-01-10 17:49 PST
,
Saam Barati
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2018-01-10 17:49:14 PST
Created
attachment 330999
[details]
patch
Yusuke Suzuki
Comment 2
2018-01-10 18:15:15 PST
Comment on
attachment 330999
[details]
patch r=me, nice catch.
WebKit Commit Bot
Comment 3
2018-01-11 00:16:11 PST
Comment on
attachment 330999
[details]
patch Clearing flags on attachment: 330999 Committed
r226767
: <
https://trac.webkit.org/changeset/226767
>
WebKit Commit Bot
Comment 4
2018-01-11 00:16:13 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5
2018-01-11 00:18:33 PST
<
rdar://problem/36430219
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug