Bug 181470 - [RenderTreeBuilder] Move RenderRuby's moveChildren logic to RenderTreeBuilder
Summary: [RenderTreeBuilder] Move RenderRuby's moveChildren logic to RenderTreeBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-09 21:13 PST by zalan
Modified: 2018-01-10 07:54 PST (History)
6 users (show)

See Also:

Attachments
Patch (15.57 KB, patch)
2018-01-09 21:17 PST, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-01-09 21:13:52 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2018-01-09 21:14:30 PST 
<rdar://problem/36397683>
Comment 2 zalan 2018-01-09 21:17:46 PST 
Created attachment 330880 [details]
Patch
Comment 3 zalan 2018-01-09 21:19:46 PST 
Comment on attachment 330880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330880&action=review

> Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp:172
> +void RenderTreeBuilder::Ruby::moveChildrenInternal(RenderRubyBase& from, RenderRubyBase& to, RenderObject* beforeChild)

Don't really like this name
Comment 4 WebKit Commit Bot 2018-01-10 07:54:36 PST 
Comment on attachment 330880 [details]
Patch

Clearing flags on attachment: 330880

Committed r226714: <https://trac.webkit.org/changeset/226714>
Comment 5 WebKit Commit Bot 2018-01-10 07:54:38 PST 
All reviewed patches have been landed.  Closing bug.