Bug 181452 – Use protectedThis for the 'updatePrevalentDomainsToPartitionOrBlockCookies' lambda

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Keith Rollin]

WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback has code that looks as follows (reformatted here to make the possible issue more apparent):

    m_resourceLoadStatistics = WebResourceLoadStatisticsStore::create(..., ..., 
        [this] (...) { ... },
        [this, protectedThis = makeRef(*this)] (...) { ... }, 
        [this, protectedThis = makeRef(*this)] (...) { ... },
        [this, protectedThis = makeRef(*this)] (...) { ... });

The possible issue is that the first lambda does not create a protectedThis. The bodies of all four lambdas just call member functions that all have similar forms. This would argue for their having the same calling/context requirements, so it seems like the first lambda should also create a protectedThis. Looking at the history of the function, it looks like the lack of a protectedThis may just be due to the way the function evolved.

[Brent Fulgham]

I think you are right!

[Radar WebKit Bug Importer]

<rdar://problem/36416912>

[Brent Fulgham]

Created attachment 330965 [details]
Patch

[Chris Dumez]

Comment on attachment 330965 [details]
Patch

r=me

[Brent Fulgham]

Committed r226742: <https://trac.webkit.org/changeset/226742>