Bug 181437 - [Payment Request] Rename ApplePayMerchantValidationEvent to MerchantValidationEvent
Summary: [Payment Request] Rename ApplePayMerchantValidationEvent to MerchantValidatio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-09 08:54 PST by Andy Estes
Modified: 2018-01-10 23:27 PST (History)
13 users (show)

See Also:

Attachments
Patch (57.26 KB, patch)
2018-01-09 08:58 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (57.05 KB, patch)
2018-01-10 10:23 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2018-01-09 08:54:30 PST 
[Payment Request] Rename ApplePayMerchantValidationEvent to MerchantValidationEvent
Comment 1 Radar WebKit Bug Importer 2018-01-09 08:55:15 PST 
<rdar://problem/36376481>
Comment 2 Andy Estes 2018-01-09 08:58:56 PST 
Created attachment 330828 [details]
Patch
Comment 3 EWS Watchlist 2018-01-09 09:02:34 PST 
Attachment 330828 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/paymentrequest/MerchantValidationEvent.cpp:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tim Horton 2018-01-09 18:00:08 PST 
Comment on attachment 330828 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330828&action=review

> LayoutTests/http/tests/paymentrequest/payment-request-merchant-validation.https.html:2
> +<!--  Copyright (C) 2018 Apple Inc. All rights reserved.  -->

?????? I don’t think so.
Comment 5 Andy Estes 2018-01-10 10:23:04 PST 
Created attachment 330928 [details]
Patch
Comment 6 WebKit Commit Bot 2018-01-10 13:10:19 PST 
The commit-queue encountered the following flaky tests while processing attachment 330928 [details]:

accessibility/mac/aria-multiple-liveregions-notification.html bug 181494 (authors: cdumez@apple.com, simon.fraser@apple.com, and zalan@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2018-01-10 13:10:21 PST 
The commit-queue encountered the following flaky tests while processing attachment 330928 [details]:

The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2018-01-10 23:27:00 PST 
Comment on attachment 330928 [details]
Patch

Clearing flags on attachment: 330928

Committed r226766: <https://trac.webkit.org/changeset/226766>
Comment 9 WebKit Commit Bot 2018-01-10 23:27:02 PST 
All reviewed patches have been landed.  Closing bug.