Bug 181314 - REGRESSION (r225709): Web Inspector: CSS Source maps not loading
Summary: REGRESSION (r225709): Web Inspector: CSS Source maps not loading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-04 18:56 PST by Joseph Pecoraro
Modified: 2018-01-04 20:34 PST (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (13.47 KB, patch)
2018-01-04 19:28 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-01-04 18:56:24 PST 
REGRESSION (r225709): Web Inspector: CSS Source maps not loading

Steps to Reproduce:
1. Load any page with CSS source maps
  => CSS source map not loaded

Notes:
• An over-eager else when we added handling of no-main-frame cases (service worker inspector).
• See: SourceMapManager _loadAndParseSourceMap
Comment 1 Joseph Pecoraro 2018-01-04 18:56:31 PST 
<rdar://problem/36177620>
Comment 2 Joseph Pecoraro 2018-01-04 19:28:15 PST 
Created attachment 330511 [details]
[PATCH] Proposed Fix
Comment 3 BJ Burg 2018-01-04 20:13:31 PST 
Comment on attachment 330511 [details]
[PATCH] Proposed Fix

r=me, nice test!
Comment 4 WebKit Commit Bot 2018-01-04 20:34:12 PST 
Comment on attachment 330511 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 330511

Committed r226435: <https://trac.webkit.org/changeset/226435>
Comment 5 WebKit Commit Bot 2018-01-04 20:34:13 PST 
All reviewed patches have been landed.  Closing bug.