Bug 181231 - REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
Summary: REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-01-02 17:47 PST by Michael Catanzaro
Modified: 2018-01-02 18:35 PST (History)
7 users (show)

See Also:


Attachments
Patch (10.63 KB, patch)
2018-01-02 17:56 PST, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2018-01-02 17:47:10 PST
r223253 broke ResourceLoadStatistics layout tests for non-Cocoa ports because it added new WebKitTestRunner API that is implemented only for Cocoa ports.
Comment 1 Michael Catanzaro 2018-01-02 17:56:55 PST
Created attachment 330360 [details]
Patch
Comment 2 Michael Catanzaro 2018-01-02 18:02:35 PST
Mmm, this one needs an owner review.
Comment 3 Alex Christensen 2018-01-02 18:09:26 PST
Comment on attachment 330360 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2018-01-02 18:34:22 PST
Comment on attachment 330360 [details]
Patch

Clearing flags on attachment: 330360

Committed r226346: <https://trac.webkit.org/changeset/226346>
Comment 5 WebKit Commit Bot 2018-01-02 18:34:23 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-01-02 18:35:18 PST
<rdar://problem/36268105>