Bug 181067 – Service Worker should expose redirect mode for navigation loads as manual

• Status: RESOLVED
• Resolution: FIXED
• Component: Service Workers

[youenn fablet]

Service Worker should expose redirect mode for navigation loads as manual

[youenn fablet]

Created attachment 329967 [details]
Patch

[youenn fablet]

Submitted web-platform-tests pull request: https://github.com/w3c/web-platform-tests/pull/8764

[EWS Watchlist]

Comment on attachment 329967 [details]
Patch

Attachment 329967 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/5782450

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect-body.https.html

[EWS Watchlist]

Created attachment 329982 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[EWS Watchlist]

Comment on attachment 329967 [details]
Patch

Attachment 329967 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5782805

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/navigation-redirect-body.https.html

[EWS Watchlist]

Created attachment 329985 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[youenn fablet]

Both tests run fine on my machine but not on bots.
Wonder whether this is due to some HTTPS setup issue.

[youenn fablet]

Created attachment 330373 [details]
Patch

[Alex Christensen]

Comment on attachment 330373 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=330373&action=review

> Source/WebCore/loader/CrossOriginAccessControl.cpp:139
> +    if (!headersToKeep.contains(HTTPHeaderName::ContentType)) {
> +        if (!isCrossOriginSafeRequestHeader(HTTPHeaderName::ContentType, request.httpContentType()))

You could just use && here

> Source/WebKit/WebProcess/Storage/ServiceWorkerClientFetch.cpp:90
> +    if ((options.redirect != FetchOptions::Redirect::Manual && options.mode != FetchOptions::Mode::Navigate) && response.tainting() == ResourceResponse::Tainting::Opaqueredirect)

This has unnecessary parentheses.

[youenn fablet]

Created attachment 330450 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 330450 [details]
Patch for landing

Clearing flags on attachment: 330450

Committed r226400: <https://trac.webkit.org/changeset/226400>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/36292980>

[youenn fablet]

Submitted web-platform-tests pull request: https://github.com/w3c/web-platform-tests/pull/9332