Bug 180991 - [Fetch] Extracting a body of type Blob should not set Content-Type to the empty string
Summary: [Fetch] Extracting a body of type Blob should not set Content-Type to the emp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Service Workers (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-19 12:47 PST by Chris Dumez
Modified: 2017-12-19 17:20 PST (History)
7 users (show)

See Also:


Attachments
Patch (3.30 KB, patch)
2017-12-19 12:48 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (2.42 MB, application/zip)
2017-12-19 13:43 PST, Build Bot
no flags Details
Patch (8.51 KB, patch)
2017-12-19 13:57 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-elcapitan (2.42 MB, application/zip)
2017-12-19 14:38 PST, Build Bot
no flags Details
Patch (13.18 KB, patch)
2017-12-19 14:47 PST, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (13.19 KB, patch)
2017-12-19 15:17 PST, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-12-19 12:47:06 PST
Extracting a body of type Blob should not Content-Type to the empty string as per:
- https://fetch.spec.whatwg.org/#concept-bodyinit-extract
Comment 1 Chris Dumez 2017-12-19 12:48:37 PST
Created attachment 329798 [details]
Patch
Comment 2 Build Bot 2017-12-19 13:43:04 PST
Comment on attachment 329798 [details]
Patch

Attachment 329798 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5757801

New failing tests:
imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.html
http/wpt/fetch/fetch-as-blob.html
http/wpt/fetch/fetch-as-blob-worker.html
imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker.html
Comment 3 Build Bot 2017-12-19 13:43:06 PST
Created attachment 329806 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 4 Chris Dumez 2017-12-19 13:57:02 PST
Created attachment 329815 [details]
Patch
Comment 5 Build Bot 2017-12-19 14:38:02 PST
Comment on attachment 329815 [details]
Patch

Attachment 329815 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5759253

New failing tests:
imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker.html
Comment 6 Build Bot 2017-12-19 14:38:04 PST
Created attachment 329829 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Chris Dumez 2017-12-19 14:47:37 PST
Created attachment 329834 [details]
Patch
Comment 8 youenn fablet 2017-12-19 15:14:43 PST
Comment on attachment 329834 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=329834&action=review

> Source/WebCore/ChangeLog:8
> +        Extracting a body of type Blob should not Content-Type to the empty string as per:

s/not/not set/
Comment 9 Chris Dumez 2017-12-19 15:17:47 PST
Created attachment 329839 [details]
Patch
Comment 10 WebKit Commit Bot 2017-12-19 17:16:02 PST
Comment on attachment 329839 [details]
Patch

Clearing flags on attachment: 329839

Committed r226162: <https://trac.webkit.org/changeset/226162>
Comment 11 WebKit Commit Bot 2017-12-19 17:16:04 PST
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2017-12-19 17:20:32 PST
<rdar://problem/36145392>