Bug 180710 - [Web Animations] Expose promises on Animation interface
Summary: [Web Animations] Expose promises on Animation interface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-12-12 11:59 PST by Antoine Quint
Modified: 2017-12-12 15:12 PST (History)
7 users (show)

See Also:


Attachments
Patch (9.52 KB, patch)
2017-12-12 12:05 PST, Antoine Quint
dino: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-12-12 11:59:32 PST
The Animation interface exposes two promises, finished and ready. Before we actually fulfil or reject them, we need to expose them.
Comment 1 Radar WebKit Bug Importer 2017-12-12 11:59:52 PST
<rdar://problem/36000604>
Comment 2 Antoine Quint 2017-12-12 12:05:49 PST
Created attachment 329136 [details]
Patch
Comment 3 WebKit Commit Bot 2017-12-12 14:40:31 PST
Comment on attachment 329136 [details]
Patch

Rejecting attachment 329136 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 329136, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 225805 = 29c4e918d56854c29a97a02f194b9ba8dcce4feb
r225806 = 496975311342d88fa6a2c570a37726db2d306c9d
r225807 = 0941cf150ab20007c12660e99b54308249ac3f2f
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/5636106
Comment 4 Antoine Quint 2017-12-12 15:12:09 PST
Committed r225812: <https://trac.webkit.org/changeset/225812>