1. Move platform/network/mac/UTIUtilities.mm to platform/graphics/cg/UTIUtilities.cpp [ reason it is not related to network ] 2. Move platform/network/mac/UTIUtilities.h to platform/graphics/cg/UTIUtilities.h [ reason it is related to image UTI for CG platform only ] 3. Move platform/graphics/cg/ImageSourceCGWin.cpp to platform/graphics/cg/UTIUtilitiesWin.cpp [ reason it not related to ImageSource ] 4. Delete platform/graphics/cg/ImageSourceCG.cpp and platform/graphics/cg/ImageSourceCG.h [ reason the functions of these files are now in platform/network/mac/UTIUtilities.h and platform/network/mac/UTIUtilities.cpp ]
Created attachment 328759 [details] Patch
Created attachment 328823 [details] Patch
Comment on attachment 328823 [details] Patch Attachment 328823 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5549083 New failing tests: fast/text/vertical-quotation-marks.html
Created attachment 328856 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 328860 [details] Patch
UTIUtilities isn’t about graphics either, so this doesn’t seem like an improvement. Honestly, network doesn’t seem like the worst place for it -- it’s all about types of resources.
Created attachment 328891 [details] Patch
Attachment 328891 [details] did not pass style-queue: ERROR: Source/WebCore/platform/UTIUtilities.cpp:38: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 328892 [details] Patch
Comment on attachment 328892 [details] Patch Attachment 328892 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5553991 Number of test failures exceeded the failure limit.
Created attachment 328894 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 328892 [details] Patch Attachment 328892 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5553997 New failing tests: fast/canvas/webgl/premultiplyalpha-test.html fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg.html
Created attachment 328895 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 328892 [details] Patch Attachment 328892 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5554127 New failing tests: fast/canvas/webgl/premultiplyalpha-test.html fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html fast/canvas/toDataURL-supportedTypes.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg.html
Created attachment 328896 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 328892 [details] Patch Attachment 328892 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5554149 New failing tests: fast/canvas/webgl/premultiplyalpha-test.html imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg.html fast/canvas/toDataURL-supportedTypes.html fast/canvas/canvas-toDataURL-case-insensitive-mimetype.html
Created attachment 328898 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Created attachment 328899 [details] Patch
Created attachment 330341 [details] Patch
Comment on attachment 330341 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330341&action=review > Source/WebCore/platform/UTIUtilities.h:2 > + * Copyright (C) 2017 Apple Inc. All rights reserved. Is this here because it’s also used for the -Win one? But then this defines lots of functions that that one doesn’t implement? Something is weird. Maybe you just need some #ifdefs around these definitions?
Created attachment 330362 [details] Patch
Comment on attachment 330362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330362&action=review > Source/WebCore/platform/UTIUtilities.h:37 > +String MIMETypeFromUTITree(const String&); Maybe a comment should explain what a "UTI tree" is? > Source/WebCore/platform/cocoa/UTIUtilities.cpp:63 > + if (typeID == CFStringGetTypeID()) > + return MIMETypeFromUTITree((CFStringRef)value); I hope we never get into an infinite loop here. Are we guaranteed that the kUTTypeConformsToKey is always different from the UTI? > Source/WebCore/platform/cocoa/UTIUtilities.cpp:88 > +public: No need for public: in a struct.
Created attachment 330414 [details] Patch
Comment on attachment 330362 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=330362&action=review >> Source/WebCore/platform/UTIUtilities.h:37 >> +String MIMETypeFromUTITree(const String&); > > Maybe a comment should explain what a "UTI tree" is? A comment was added. >> Source/WebCore/platform/cocoa/UTIUtilities.cpp:63 >> + return MIMETypeFromUTITree((CFStringRef)value); > > I hope we never get into an infinite loop here. Are we guaranteed that the kUTTypeConformsToKey is always different from the UTI? kUTTypeConformsToKey should return the parent(s) in the conformance tree of the given UTI. The conformance hierarchy can't have cycles but can have multiple parents because it supports multiple inheritance. See https://developer.apple.com/library/content/documentation/FileManagement/Conceptual/understanding_utis/understand_utis_conc/understand_utis_conc.html#//apple_ref/doc/uid/TP40001319-CH202-SW4 >> Source/WebCore/platform/cocoa/UTIUtilities.cpp:88 >> +public: > > No need for public: in a struct. Fixed.
Comment on attachment 330414 [details] Patch Unfortunately, this old patch no longer applies.