RESOLVED FIXED 180168
Populate self.registration.installing/waiting/active inside service workers 
https://bugs.webkit.org/show_bug.cgi?id=180168
Summary Populate self.registration.installing/waiting/active inside service workers
Chris Dumez
Reported 2017-11-29 14:26:19 PST
Populate self.registration.installing/waiting/active inside service workers.
Attachments
WIP Patch (16.46 KB, patch)
2017-11-29 15:57 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (2.56 MB, application/zip)
2017-11-29 17:13 PST, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.25 MB, application/zip)
2017-11-29 17:21 PST, EWS Watchlist 		no flags
Details
Patch (24.51 KB, patch)
2017-11-30 10:13 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-11-29 15:57:56 PST
Created attachment 327917 [details] WIP Patch
EWS Watchlist
Comment 2 2017-11-29 17:13:02 PST
Comment on attachment 327917 [details] WIP Patch Attachment 327917 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5410820 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https.html
EWS Watchlist
Comment 3 2017-11-29 17:13:03 PST
Created attachment 327931 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
EWS Watchlist
Comment 4 2017-11-29 17:21:52 PST
Comment on attachment 327917 [details] WIP Patch Attachment 327917 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5410792 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/ServiceWorkerGlobalScope/registration-attribute.https.html
EWS Watchlist
Comment 5 2017-11-29 17:21:53 PST
Created attachment 327933 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Chris Dumez
Comment 6 2017-11-30 10:13:13 PST
Created attachment 327987 [details] Patch
Brady Eidson
Comment 7 2017-11-30 12:26:14 PST
Comment on attachment 327987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=327987&action=review > Source/WTF/wtf/CrossThreadCopier.h:144 > +template<typename T> struct CrossThreadCopierBase<false, false, std::optional<T>> { Nice > Source/WebCore/workers/service/ServiceWorker.cpp:-72 > - // FIXME: Once we support service workers from workers, this might need to change. > - RELEASE_ASSERT(isMainThread()); I was right!!!
Chris Dumez
Comment 8 2017-11-30 12:40:26 PST
Comment on attachment 327987 [details] Patch Clearing flags on attachment: 327987 Committed r225341: <https://trac.webkit.org/changeset/225341>
Chris Dumez
Comment 9 2017-11-30 12:40:27 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2017-11-30 12:41:22 PST
<rdar://problem/35779667>
Note You need to log in before you can comment on or make changes to this bug.