Bug 179975 - [Web Animations] Allow getComputedStyle() to return animated values for accelerated animations
Summary: [Web Animations] Allow getComputedStyle() to return animated values for accel...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-23 06:53 PST by Antoine Quint
Modified: 2017-11-24 05:30 PST (History)
5 users (show)

See Also:


Attachments
Patch (11.21 KB, patch)
2017-11-24 02:43 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (2.27 MB, application/zip)
2017-11-24 03:47 PST, Build Bot
no flags Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (3.01 MB, application/zip)
2017-11-24 04:06 PST, Build Bot
no flags Details
Patch (11.14 KB, patch)
2017-11-24 04:09 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (11.13 KB, patch)
2017-11-24 05:08 PST, Antoine Quint
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2017-11-23 06:53:58 PST
The patch for https://bugs.webkit.org/show_bug.cgi?id=179973 will make animations running with hardware composition stop returning animated values when querying the computed style.
Comment 1 Radar WebKit Bug Importer 2017-11-23 07:59:45 PST
<rdar://problem/35676811>
Comment 2 Antoine Quint 2017-11-24 02:43:23 PST
Created attachment 327531 [details]
Patch
Comment 3 Dean Jackson 2017-11-24 02:55:43 PST
Comment on attachment 327531 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=327531&action=review

> LayoutTests/http/wpt/wk-web-animations/interfaces/keyframe-effect-getComputedStyle.html:38
> +hwTest.step(() => {

I'm digging the syntax "_ => { }" for these cases
Comment 4 Build Bot 2017-11-24 03:47:07 PST
Comment on attachment 327531 [details]
Patch

Attachment 327531 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/5347869

New failing tests:
transforms/3d/general/prefixed-3dtransform-values.html
transitions/steps-timing-function.html
animations/fill-mode-transform.html
media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html
animations/keyframe-multiple-timing-functions-transform.html
media/video-controls-visible-exiting-fullscreen.html
animations/change-transform-style-during-animation.html
media/modern-media-controls/button/button-active-state.html
fast/css/getComputedStyle/computed-style-with-zoom.html
animations/animation-direction-reverse-fill-mode-hardware.html
fullscreen/video-controls-rtl.html
media/modern-media-controls/background-tint/background-tint.html
css3/filters/backdrop/backdropfilter-property-computed-style.html
compositing/animation/computed-style-during-delay.html
animations/3d/replace-filling-transform.html
transitions/extra-transition.html
transforms/3d/general/3dtransform-values.html
Comment 5 Build Bot 2017-11-24 03:47:08 PST
Created attachment 327537 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-11-24 04:06:29 PST
Comment on attachment 327531 [details]
Patch

Attachment 327531 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/5347964

New failing tests:
transforms/3d/general/prefixed-3dtransform-values.html
transitions/steps-timing-function.html
animations/fill-mode-transform.html
media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html
animations/keyframe-multiple-timing-functions-transform.html
media/video-controls-visible-exiting-fullscreen.html
animations/change-transform-style-during-animation.html
media/modern-media-controls/button/button-active-state.html
fast/css/getComputedStyle/computed-style-with-zoom.html
animations/animation-direction-reverse-fill-mode-hardware.html
fullscreen/video-controls-rtl.html
media/modern-media-controls/background-tint/background-tint.html
css3/filters/backdrop/backdropfilter-property-computed-style.html
compositing/animation/computed-style-during-delay.html
animations/3d/replace-filling-transform.html
transitions/extra-transition.html
transforms/3d/general/3dtransform-values.html
Comment 7 Build Bot 2017-11-24 04:06:31 PST
Created attachment 327539 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 8 Antoine Quint 2017-11-24 04:09:57 PST
Created attachment 327540 [details]
Patch
Comment 9 Antoine Quint 2017-11-24 05:08:50 PST
Created attachment 327544 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2017-11-24 05:10:26 PST
Comment on attachment 327544 [details]
Patch for landing

Rejecting attachment 327544 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 327544, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/5348815
Comment 11 Antoine Quint 2017-11-24 05:30:43 PST
Committed r225133: <https://trac.webkit.org/changeset/225133>