Bug 179962 - Web Inspector: Styles Redesign: selector moves up when focused
Summary: Web Inspector: Styles Redesign: selector moves up when focused
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-22 17:34 PST by Nikita Vasilyev
Modified: 2017-12-15 17:57 PST (History)
3 users (show)

See Also:


Attachments
[Animated GIF] Bug (78.38 KB, image/gif)
2017-11-22 17:34 PST, Nikita Vasilyev
no flags Details
Patch (3.07 KB, patch)
2017-12-14 21:53 PST, Devin Rousso
nvasilyev: review-
Details | Formatted Diff | Diff
[Image] After Patch is applied (39.83 KB, image/png)
2017-12-14 21:53 PST, Devin Rousso
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2017-11-22 17:34:30 PST
Created attachment 327477 [details]
[Animated GIF] Bug

Introduced in: Bug 179588 - Web Inspector: Styles Redesign: make selector field inline-block when editing

I tried to be clever, but didn't take into account the case when the source location takes the whole line.
Comment 1 Radar WebKit Bug Importer 2017-11-22 17:34:47 PST
<rdar://problem/35670982>
Comment 2 Devin Rousso 2017-12-14 21:53:17 PST
Created attachment 329459 [details]
Patch
Comment 3 Devin Rousso 2017-12-14 21:53:39 PST
Created attachment 329460 [details]
[Image] After Patch is applied
Comment 4 Nikita Vasilyev 2017-12-15 17:57:26 PST
Comment on attachment 329459 [details]
Patch

Let me mull it over.

My comment in https://bugs.webkit.org/show_bug.cgi?id=180793#c4 applies here as well.
I don't want to change it back to `display: inline` because text selection looks ugly.