Bug 179930 - [AppleWin] Ninja does not build WebKitQuartzCoreAdditions
Summary: [AppleWin] Ninja does not build WebKitQuartzCoreAdditions
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-21 15:49 PST by Don Olmstead
Modified: 2023-03-14 01:22 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-11-21 15:49:31 PST 
Ninja fails when attempting to build WebKitQuartzCoreAdditions

if (${MSVC_CXX_ARCHITECTURE_ID} STREQUAL "X86")
    link_directories($(WINDOWSSDKDIR)Lib/$(WINDOWSSDKLIBVERSION)/um/x86)
else ()
    link_directories($(WINDOWSSDKDIR)Lib/$(WINDOWSSDKLIBVERSION)/um/x64)
endif ()

The above uses MSBuild syntax for the link directories.

Using $ENV{WINDOWSSDKDIR} and $ENV{WINDOWSSDKLIBVERSION} seem to work. Should probably use cmake paths to make the path pretty.
Comment 1 Fujii Hironori 2023-03-14 01:22:32 PDT 
AppleWin was removed.