Bug 179369 - WebDriver: capabilities with null value shouldn't be added to the validated capabilities object
Summary: WebDriver: capabilities with null value shouldn't be added to the validated c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-11-07 03:21 PST by Carlos Garcia Campos
Modified: 2017-11-15 09:40 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2017-11-07 03:24 PST, Carlos Garcia Campos 		bburg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-11-07 03:21:46 PST 
https://w3c.github.io/webdriver/webdriver-spec.html#dfn-validate-capabilities

"4. If deserialized is not null, set a property on result with name name and value deserialized."

We are adding it, causing a failure when matching capabilities.
Comment 1 Carlos Garcia Campos 2017-11-07 03:24:35 PST 
Created attachment 326202 [details]
Patch
Comment 2 BJ Burg 2017-11-09 13:53:48 PST 
Comment on attachment 326202 [details]
Patch

r=me
Comment 3 Carlos Garcia Campos 2017-11-09 23:26:07 PST 
Committed r224667: <https://trac.webkit.org/changeset/224667>
Comment 4 Radar WebKit Bug Importer 2017-11-15 09:40:04 PST 
<rdar://problem/35562186>