WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
179038
[WPE][GTK] Always use SET_AND_EXPOSE_TO_BUILD to set build variables
https://bugs.webkit.org/show_bug.cgi?id=179038
Summary
[WPE][GTK] Always use SET_AND_EXPOSE_TO_BUILD to set build variables
Michael Catanzaro
Reported
2017-10-30 17:28:37 PDT
Always use SET_AND_EXPOSE_TO_BUILD to set build variables (as noted by Tom) This doesn't actually fix anything, but it's quite risky not to do so, as build defines could wind up set to unexpected values.
Attachments
Patch
(2.71 KB, patch)
2017-10-30 19:40 PDT
,
Michael Catanzaro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2017-10-30 19:40:04 PDT
Created
attachment 325413
[details]
Patch
WebKit Commit Bot
Comment 2
2017-11-06 06:43:44 PST
Comment on
attachment 325413
[details]
Patch Clearing flags on attachment: 325413 Committed
r224490
: <
https://trac.webkit.org/changeset/224490
>
WebKit Commit Bot
Comment 3
2017-11-06 06:43:45 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug