178887 – [Payment Request] Restrict API use to secure, same-origin frames

Bug 178887 - [Payment Request] Restrict API use to secure, same-origin frames

Summary: [Payment Request] Restrict API use to secure, same-origin frames

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Andy Estes

URL:
Keywords:	InRadar

Depends on:
Blocks:	174796
	Show dependency tree / graph

Reported:	2017-10-26 14:44 PDT by Andy Estes
Modified:	2017-11-15 12:41 PST (History)
CC List:	8 users (show)

See Also:

Attachments
Patch (19.84 KB, patch) 2017-10-26 14:46 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (20.13 KB, patch) 2017-10-26 15:00 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (20.21 KB, patch) 2017-10-26 15:05 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (21.19 KB, patch) 2017-10-26 15:56 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andy Estes 2017-10-26 14:44:21 PDT

[Payment Request] Restrict API use to secure, same-origin frames

Comment 1 Andy Estes 2017-10-26 14:46:41 PDT Comment hidden (obsolete)

Created attachment 325058 [details]
Patch

Comment 2 Andy Estes 2017-10-26 15:00:17 PDT Comment hidden (obsolete)

Created attachment 325059 [details]
Patch

Comment 3 Andy Estes 2017-10-26 15:05:05 PDT Comment hidden (obsolete)

Created attachment 325061 [details]
Patch

Comment 4 WebKit Commit Bot 2017-10-26 15:53:40 PDT Comment hidden (obsolete)

Comment on attachment 325061 [details]
Patch

Rejecting attachment 325061 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 325061, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
yment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/5004082

Comment 5 Andy Estes 2017-10-26 15:56:25 PDT

Created attachment 325070 [details]
Patch

Comment 6 WebKit Commit Bot 2017-10-26 16:25:14 PDT

The commit-queue encountered the following flaky tests while processing attachment 325070 [details]:

media/modern-media-controls/seek-backward-support/seek-backward-support.html bug 174916 (authors: graouts@apple.com, mcatanzaro@igalia.com, and ryanhaddad@apple.com)
The commit-queue is continuing to process your patch.

Comment 7 WebKit Commit Bot 2017-10-26 16:25:45 PDT

Comment on attachment 325070 [details]
Patch

Clearing flags on attachment: 325070

Committed r224061: <https://trac.webkit.org/changeset/224061>

Comment 8 WebKit Commit Bot 2017-10-26 16:25:46 PDT

All reviewed patches have been landed.  Closing bug.

Comment 9 Keith Miller 2017-10-26 16:28:35 PDT

Committed r224062: <https://trac.webkit.org/changeset/224062>

Comment 10 Radar WebKit Bug Importer 2017-11-15 12:41:30 PST

<rdar://problem/35567954>