Add NoEventDispatchAssertion to Document::updateStyle and Document::updateStyleIfNeeded.
<rdar://problem/35106129>
Created attachment 324956 [details] Adds assertions
Attachment 324956 [details] did not pass style-queue: ERROR: Source/WebCore/dom/EventDispatcher.cpp:133: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 324956 [details] Adds assertions Attachment 324956 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4994171 Number of test failures exceeded the failure limit.
Created attachment 324960 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
mac-wk2 EWS bot is in a really bad shape :(
Created attachment 324962 [details] Reverted inspector change
Attachment 324962 [details] did not pass style-queue: ERROR: Source/WebCore/dom/EventDispatcher.cpp:133: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
cool, r=me
Created attachment 324969 [details] Patch for landing
Comment on attachment 324969 [details] Patch for landing Wait for EWS first.
Attachment 324969 [details] did not pass style-queue: ERROR: Source/WebCore/dom/EventDispatcher.cpp:133: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 324969 [details] Patch for landing Clearing flags on attachment: 324969 Committed r224011: <https://trac.webkit.org/changeset/224011>
All reviewed patches have been landed. Closing bug.
Because I rolled out https://trac.webkit.org/changeset/223999/webkit, xsl LayoutTests are hitting the assert added in this change. Example: https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r224117%20(4523)/results.html
Reverted r224011 for reason: xsl LayoutTests hit an assertion added with this change since r223999 was rolled out. Committed r224131: <https://trac.webkit.org/changeset/224131>
Created attachment 325283 [details] Patch
Attachment 325283 [details] did not pass style-queue: ERROR: Source/WebCore/dom/EventDispatcher.cpp:133: Please replace ASSERT_WITH_SECURITY_IMPLICATION() with RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(). [security/assertion] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 325283 [details] Patch Relanding the patch since the flakiness of the tests has been fixed.
Comment on attachment 325283 [details] Patch Clearing flags on attachment: 325283 Committed r224159: <https://trac.webkit.org/changeset/224159>