178765 – [Apple Pay] Implement a paymentmethodselected event for PaymentRequest

Bug 178765 - [Apple Pay] Implement a paymentmethodselected event for PaymentRequest

Summary: [Apple Pay] Implement a paymentmethodselected event for PaymentRequest

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	New Bugs (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Andy Estes

URL:
Keywords:	InRadar

Depends on:
Blocks:	174796
	Show dependency tree / graph

Reported:	2017-10-24 16:58 PDT by Andy Estes
Modified:	2017-10-24 17:53 PDT (History)
CC List:	12 users (show)

See Also:

Attachments
Patch (47.05 KB, patch) 2017-10-24 17:02 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (47.15 KB, patch) 2017-10-24 17:10 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Patch (47.12 KB, patch) 2017-10-24 17:31 PDT, Andy Estes	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andy Estes 2017-10-24 16:58:41 PDT

[Apple Pay] Implement a paymentmethodselected event for PaymentRequest

Comment 1 Andy Estes 2017-10-24 17:02:11 PDT Comment hidden (obsolete)

Created attachment 324762 [details]
Patch

Comment 2 Build Bot 2017-10-24 17:03:47 PDT Comment hidden (obsolete)

Attachment 324762 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.cpp:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Andy Estes 2017-10-24 17:10:42 PDT Comment hidden (obsolete)

Created attachment 324763 [details]
Patch

Comment 4 Build Bot 2017-10-24 17:12:49 PDT Comment hidden (obsolete)

Attachment 324763 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.cpp:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Andy Estes 2017-10-24 17:31:45 PDT

Created attachment 324767 [details]
Patch

Comment 6 WebKit Commit Bot 2017-10-24 17:52:07 PDT

Comment on attachment 324767 [details]
Patch

Clearing flags on attachment: 324767

Committed r223945: <https://trac.webkit.org/changeset/223945>

Comment 7 WebKit Commit Bot 2017-10-24 17:52:09 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 Radar WebKit Bug Importer 2017-10-24 17:53:53 PDT

<rdar://problem/35164055>