178765 – [Apple Pay] Implement a paymentmethodselected event for PaymentRequest

RESOLVED FIXED Bug 178765

[Apple Pay] Implement a paymentmethodselected event for PaymentRequest

https://bugs.webkit.org/show_bug.cgi?id=178765

Summary [Apple Pay] Implement a paymentmethodselected event for PaymentRequest

Andy Estes

Reported 2017-10-24 16:58:41 PDT

[Apple Pay] Implement a paymentmethodselected event for PaymentRequest

Attachments
Patch (47.05 KB, patch) 2017-10-24 17:02 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (47.15 KB, patch) 2017-10-24 17:10 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (47.12 KB, patch) 2017-10-24 17:31 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2017-10-24 17:02:11 PDT Comment hidden (obsolete)

Created attachment 324762 [details] Patch

Build Bot

Comment 2 2017-10-24 17:03:47 PDT Comment hidden (obsolete)

Attachment 324762 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.cpp:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 3 2017-10-24 17:10:42 PDT Comment hidden (obsolete)

Created attachment 324763 [details] Patch

Build Bot

Comment 4 2017-10-24 17:12:49 PDT Comment hidden (obsolete)

Attachment 324763 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentMethodUpdateEvent.cpp:37: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 5 2017-10-24 17:31:45 PDT

Created attachment 324767 [details] Patch

WebKit Commit Bot

Comment 6 2017-10-24 17:52:07 PDT

Comment on attachment 324767 [details] Patch Clearing flags on attachment: 324767 Committed r223945: <https://trac.webkit.org/changeset/223945>

WebKit Commit Bot

Comment 7 2017-10-24 17:52:09 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 8 2017-10-24 17:53:53 PDT

<rdar://problem/35164055>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Andy Estes

Reported

2017-10-24 16:58 PDT

Modified

2017-10-24 17:53 PDT History

CC List

12 users Show

URL

Keywords InRadar

Depends on

Blocks

174796

Dependancies

tree graph