Bug 178760 - Move inspector and loader to unified sources.
Summary: Move inspector and loader to unified sources.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-24 16:21 PDT by Keith Miller
Modified: 2017-11-15 12:52 PST (History)
2 users (show)

See Also:

Attachments
Patch (168.30 KB, patch)
2017-10-24 16:23 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (168.58 KB, patch)
2017-10-24 16:57 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (168.58 KB, patch)
2017-10-24 16:58 PDT, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-10-24 16:21:54 PDT 
Move inspector and loader to unified sources.
Comment 1 Keith Miller 2017-10-24 16:23:18 PDT 
Created attachment 324748 [details]
Patch
Comment 2 Keith Miller 2017-10-24 16:57:37 PDT 
Created attachment 324760 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2017-10-24 16:58:28 PDT 
Comment on attachment 324760 [details]
Patch for landing

Rejecting attachment 324760 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 324760, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/4976917
Comment 4 Keith Miller 2017-10-24 16:58:58 PDT 
Created attachment 324761 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-10-24 17:33:17 PDT 
Comment on attachment 324761 [details]
Patch for landing

Clearing flags on attachment: 324761

Committed r223942: <https://trac.webkit.org/changeset/223942>
Comment 6 WebKit Commit Bot 2017-10-24 17:33:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 12:52:20 PST 
<rdar://problem/35568315>