Bug 178638 - Web Inspector: Styles Redesign: Inline widgets don't hide when starting editing by tabbing from property name
Summary: Web Inspector: Styles Redesign: Inline widgets don't hide when starting editi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-21 16:37 PDT by Nikita Vasilyev
Modified: 2017-11-15 12:57 PST (History)
4 users (show)

See Also:


Attachments
[Animated GIF] Bug (85.48 KB, image/gif)
2017-10-21 16:37 PDT, Nikita Vasilyev
no flags Details
Patch (1.59 KB, patch)
2017-10-21 16:44 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff
[Animated GIF] With patch applied (49.30 KB, image/gif)
2017-10-21 16:46 PDT, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2017-10-21 16:37:47 PDT
Created attachment 324508 [details]
[Animated GIF] Bug

Inline swatches (WI.InlineSwatch), like a color picker, should only show when the property is not being edited.

Clicking on a property value hides inline swatches as expected.
Tabbing from a property name to a property value does not.
Comment 1 Nikita Vasilyev 2017-10-21 16:44:48 PDT
Created attachment 324509 [details]
Patch
Comment 2 Nikita Vasilyev 2017-10-21 16:46:17 PDT
Created attachment 324510 [details]
[Animated GIF] With patch applied
Comment 3 Joseph Pecoraro 2017-10-23 17:12:33 PDT
Comment on attachment 324509 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2017-10-23 17:35:46 PDT
Comment on attachment 324509 [details]
Patch

Clearing flags on attachment: 324509

Committed r223867: <https://trac.webkit.org/changeset/223867>
Comment 5 WebKit Commit Bot 2017-10-23 17:35:47 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-11-15 12:57:24 PST
<rdar://problem/35568468>