Bug 178482 - Global constructors exposed to service workers should go on ServiceWorkerGlobalScope interface
Summary: Global constructors exposed to service workers should go on ServiceWorkerGlob...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar, WebExposed
Depends on:
Blocks: 178469
  Show dependency tree / graph
 
Reported: 2017-10-18 13:12 PDT by Chris Dumez
Modified: 2017-10-18 14:39 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2017-10-18 13:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-10-18 13:12:46 PDT 
Global constructors exposed to service workers should go on ServiceWorkerGlobalScope interface, not the ServiceWorker interface.
Comment 1 Chris Dumez 2017-10-18 13:14:13 PDT 
Created attachment 324159 [details]
Patch
Comment 2 Sam Weinig 2017-10-18 14:36:01 PDT 
Comment on attachment 324159 [details]
Patch

No testing this yet?
Comment 3 Chris Dumez 2017-10-18 14:37:00 PDT 
(In reply to Sam Weinig from comment #2)
> Comment on attachment 324159 [details]
> Patch
> 
> No testing this yet?

No, service worker is not quite there yet :/
Comment 4 Chris Dumez 2017-10-18 14:37:37 PDT 
Comment on attachment 324159 [details]
Patch

Clearing flags on attachment: 324159

Committed r223629: <https://trac.webkit.org/changeset/223629>
Comment 5 Chris Dumez 2017-10-18 14:37:39 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-10-18 14:38:44 PDT 
<rdar://problem/35061040>