Bug 178282 - Web Inspector: send a DOM node with each Canvas payload and eliminate Canvas.requestNode
Summary: Web Inspector: send a DOM node with each Canvas payload and eliminate Canvas....
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on:
Blocks: WebInspectorCanvasRecording
  Show dependency treegraph
Reported: 2017-10-13 13:30 PDT by Devin Rousso
Modified: 2018-09-19 21:13 PDT (History)
3 users (show)

See Also:

[Patch] WIP (42.38 KB, patch)
2017-12-04 17:05 PST, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-10-13 13:30:28 PDT
All the UI that relates to Canvas uses the canvas' node.  We currently get the node via a protocol method, but since we always need the node in the UI, we might as well save a trip and just include the nodeId in the Canvas payload.  Doing this will eliminate the need for Canvas.requestNode.
Comment 1 Radar WebKit Bug Importer 2017-12-04 16:40:08 PST
Comment 2 Devin Rousso 2017-12-04 17:05:35 PST
Created attachment 328416 [details]
[Patch] WIP

I probably should've uploaded this earlier, but I tried doing some of this at the WebKit Contributors Meeting.  I kept running into an issue with how the document is fetched by the frontend, and how in doing so it would clear all the previously retrieved IDs, meaning that any we sent to the frontend for the Canvases would effectively be wiped out.