Bug 178200 - Layout Test http/tests/cache-storage/cache-clearing.https.html is failing
Summary: Layout Test http/tests/cache-storage/cache-clearing.https.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-11 18:27 PDT by Per Arne Vollan
Modified: 2017-10-12 17:37 PDT (History)
10 users (show)

See Also:

Attachments
Patch (23.96 KB, patch)
2017-10-12 14:41 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (25.06 KB, patch)
2017-10-12 15:04 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Fixing mac32bit (25.09 KB, patch)
2017-10-12 16:10 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-10-11 18:27:35 PDT 
The following layout test is failing on Windows:

http/tests/cache-storage/cache-clearing.https.html
Comment 1 youenn fablet 2017-10-12 14:41:34 PDT 
Created attachment 323567 [details]
Patch
Comment 2 youenn fablet 2017-10-12 15:04:18 PDT 
Created attachment 323573 [details]
Patch
Comment 3 youenn fablet 2017-10-12 16:10:14 PDT 
Created attachment 323588 [details]
Fixing mac32bit
Comment 4 Chris Dumez 2017-10-12 16:17:31 PDT 
Comment on attachment 323588 [details]
Fixing mac32bit

View in context: https://bugs.webkit.org/attachment.cgi?id=323588&action=review

> LayoutTests/TestExpectations:470
> +webkit.org/b/178034 http/tests/cache-storage/cache-clearing-all.https.html [ Pass Timeout ]

Eh.. isn't this patch supposed to fix the flakiness?
Comment 5 youenn fablet 2017-10-12 16:22:30 PDT 
Yes, but I was not able to reproduce the time out locally, so I would prefer to land it like this and remove the expectation after confirming this through the dashboard
Comment 6 WebKit Commit Bot 2017-10-12 17:36:11 PDT 
Comment on attachment 323588 [details]
Fixing mac32bit

Clearing flags on attachment: 323588

Committed r223265: <https://trac.webkit.org/changeset/223265>
Comment 7 WebKit Commit Bot 2017-10-12 17:36:13 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-10-12 17:37:28 PDT 
<rdar://problem/34968087>