Bug 178196 - Don't assert if mix-blend-mode is set to a non-separable blend mode on a composited layer
Summary: Don't assert if mix-blend-mode is set to a non-separable blend mode on a comp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-11 17:26 PDT by Simon Fraser (smfr)
Modified: 2017-10-12 14:13 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.18 KB, patch)
2017-10-11 17:27 PDT, Simon Fraser (smfr)
dbates: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-10-11 17:26:06 PDT
Don't assert if mix-blend-mode is set to a non-separable blend mode on a composited layer
Comment 1 Simon Fraser (smfr) 2017-10-11 17:27:20 PDT
Created attachment 323494 [details]
Patch
Comment 2 Simon Fraser (smfr) 2017-10-11 17:28:01 PDT
rdar://problem/34942337
Comment 3 Daniel Bates 2017-10-11 22:54:05 PDT
Comment on attachment 323494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323494&action=review

> LayoutTests/compositing/filters/blend-mode-saturation.html:2
> +

Please remove this empty line as I do not feel it improves the readability of this file.
Comment 4 Daniel Bates 2017-10-11 22:55:03 PDT
Comment on attachment 323494 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323494&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=178196

Please add the radar URL under this line.
Comment 5 Simon Fraser (smfr) 2017-10-12 14:13:08 PDT
https://trac.webkit.org/r223254