Bug 178103 - Disable INPUT_TYPE_COLOR in FeatureDefines.h
Summary: Disable INPUT_TYPE_COLOR in FeatureDefines.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-09 17:14 PDT by Tim Horton
Modified: 2017-10-09 18:21 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2017-10-09 17:15 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-10-09 17:14:49 PDT 
Disable INPUT_TYPE_COLOR in FeatureDefines.h
Comment 1 Tim Horton 2017-10-09 17:15:01 PDT 
Created attachment 323248 [details]
Patch
Comment 2 Tim Horton 2017-10-09 17:15:49 PDT 
Comment on attachment 323248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323248&action=review

> Source/WTF/ChangeLog:13
> +        to depend on the xcconfig defining it.

To be clear, there is a global "if !defined, #define to 0" below, so it will always be defined to /something/.
Comment 3 WebKit Commit Bot 2017-10-09 18:20:38 PDT 
Comment on attachment 323248 [details]
Patch

Clearing flags on attachment: 323248

Committed r223111: <http://trac.webkit.org/changeset/223111>
Comment 4 WebKit Commit Bot 2017-10-09 18:20:39 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-10-09 18:21:00 PDT 
<rdar://problem/34900452>