Bug 177985 - Fix the Mac CMake build
Summary: Fix the Mac CMake build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-05 18:03 PDT by Tim Horton
Modified: 2017-10-05 20:08 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.22 KB, patch)
2017-10-05 18:03 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (2.23 KB, patch)
2017-10-05 19:48 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-10-05 18:03:20 PDT
Fix the Mac CMake build
Comment 1 Tim Horton 2017-10-05 18:03:42 PDT
Created attachment 322956 [details]
Patch
Comment 2 WebKit Commit Bot 2017-10-05 18:05:41 PDT
Comment on attachment 322956 [details]
Patch

Rejecting attachment 322956 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 322956, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebKit/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/4774955
Comment 3 Tim Horton 2017-10-05 19:48:15 PDT
Created attachment 322972 [details]
Patch
Comment 4 WebKit Commit Bot 2017-10-05 20:06:38 PDT
Comment on attachment 322972 [details]
Patch

Clearing flags on attachment: 322972

Committed r222955: <http://trac.webkit.org/changeset/222955>
Comment 5 WebKit Commit Bot 2017-10-05 20:06:40 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-10-05 20:08:19 PDT
<rdar://problem/34849751>