Bug 177923 - Disable bmalloc when running Valgrind
Summary: Disable bmalloc when running Valgrind
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Turner
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-05 01:50 PDT by Charlie Turner
Modified: 2017-10-06 02:04 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.50 KB, patch)
2017-10-05 01:50 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch for landing (1.50 KB, patch)
2017-10-06 01:17 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch for landing (1.52 KB, patch)
2017-10-06 01:21 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Turner 2017-10-05 01:50:15 PDT 
Disable bmalloc when running Valgrind
Comment 1 Charlie Turner 2017-10-05 01:50:46 PDT 
Created attachment 322807 [details]
Patch
Comment 2 Charlie Turner 2017-10-06 01:17:35 PDT 
Created attachment 322997 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2017-10-06 01:18:13 PDT 
Comment on attachment 322997 [details]
Patch for landing

Rejecting attachment 322997 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 322997, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/4778937
Comment 4 Charlie Turner 2017-10-06 01:21:55 PDT 
Created attachment 322998 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-10-06 02:01:26 PDT 
Comment on attachment 322998 [details]
Patch for landing

Clearing flags on attachment: 322998

Committed r222970: <http://trac.webkit.org/changeset/222970>
Comment 6 WebKit Commit Bot 2017-10-06 02:01:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-10-06 02:04:00 PDT 
<rdar://problem/34852450>