Bug 177769 - Implement quality-of-service tiers in WebCoreDecompressionSession
Summary: Implement quality-of-service tiers in WebCoreDecompressionSession
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-02 13:17 PDT by Jer Noble
Modified: 2017-10-03 12:56 PDT (History)
3 users (show)

See Also:

Attachments
Patch (12.11 KB, patch)
2017-10-02 13:20 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (11.85 KB, patch)
2017-10-02 13:37 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (17.64 KB, patch)
2017-10-02 15:12 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (17.64 KB, patch)
2017-10-02 15:33 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (18.05 KB, patch)
2017-10-03 09:12 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-10-02 13:17:42 PDT 
Implement quality-of-service tiers in WebCoreDecompressionSession
Comment 1 Jer Noble 2017-10-02 13:20:31 PDT 
Created attachment 322418 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-10-02 13:20:41 PDT 
<rdar://problem/34774531>
Comment 3 Radar WebKit Bug Importer 2017-10-02 13:20:45 PDT 
<rdar://problem/34774533>
Comment 4 Dean Jackson 2017-10-02 13:29:56 PDT 
Comment on attachment 322418 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322418&action=review

> Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:269
> +        LOG(Media, "WebCoreDecompressionSession::decodeSample(%p) - decoding took %g%% of duration (%gs vs. %gs)", this, 100. * deltaRatio, delta, duration);

Won't this produce a LOT of log spew? Maybe do it every N frames as an average?
Comment 5 Jer Noble 2017-10-02 13:32:49 PDT 
(In reply to Dean Jackson from comment #4)
> Comment on attachment 322418 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=322418&action=review
> 
> > Source/WebCore/platform/graphics/cocoa/WebCoreDecompressionSession.mm:269
> > +        LOG(Media, "WebCoreDecompressionSession::decodeSample(%p) - decoding took %g%% of duration (%gs vs. %gs)", this, 100. * deltaRatio, delta, duration);
> 
> Won't this produce a LOT of log spew? Maybe do it every N frames as an
> average?

Sure we can drop it. The "every N frames as an average" is the logging in updateQosWithDecodeTimeStatistics().
Comment 6 Jer Noble 2017-10-02 13:37:03 PDT 
Created attachment 322422 [details]
Patch for landing
Comment 7 Jer Noble 2017-10-02 15:12:02 PDT 
Created attachment 322452 [details]
Patch for landing
Comment 8 Jer Noble 2017-10-02 15:33:41 PDT 
Created attachment 322460 [details]
Patch for landing
Comment 9 Jer Noble 2017-10-03 09:12:50 PDT 
Created attachment 322530 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2017-10-03 12:56:38 PDT 
Comment on attachment 322530 [details]
Patch for landing

Clearing flags on attachment: 322530

Committed r222803: <http://trac.webkit.org/changeset/222803>
Comment 11 WebKit Commit Bot 2017-10-03 12:56:40 PDT 
All reviewed patches have been landed.  Closing bug.