WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
177756
Remove no longer needed WebRTC build infrastructure
https://bugs.webkit.org/show_bug.cgi?id=177756
Summary
Remove no longer needed WebRTC build infrastructure
youenn fablet
Reported
2017-10-02 10:54:02 PDT
Some files are no longer needed
Attachments
Patch
(1.99 MB, patch)
2017-10-02 10:57 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch
(1.99 MB, patch)
2017-10-02 14:28 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Patch for landing
(1.99 MB, patch)
2017-10-03 09:16 PDT
,
youenn fablet
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
youenn fablet
Comment 1
2017-10-02 10:57:33 PDT
Created
attachment 322392
[details]
Patch
youenn fablet
Comment 2
2017-10-02 14:28:35 PDT
Created
attachment 322437
[details]
Patch
Alejandro G. Castro
Comment 3
2017-10-03 02:56:47 PDT
Comment on
attachment 322437
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=322437&action=review
LGTM, with the small comment.
> Source/WebCore/WebCore.xcodeproj/project.pbxproj:29229 > + 41B28AEA1F828F6B00FB52AC /* LibWebRTCProviderCocoa.h in Headers */,
Is this part of the patch?
> Source/WebCore/WebCore.xcodeproj/project.pbxproj:33316 > + 41B28AE91F828F6800FB52AC /* LibWebRTCProviderCocoa.cpp in Sources */,
Ditto.
youenn fablet
Comment 4
2017-10-03 09:16:13 PDT
Created
attachment 322531
[details]
Patch for landing
youenn fablet
Comment 5
2017-10-03 09:17:08 PDT
Thanks for the review. (In reply to Alejandro G. Castro from
comment #3
)
> Comment on
attachment 322437
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=322437&action=review
> > LGTM, with the small comment. > > > Source/WebCore/WebCore.xcodeproj/project.pbxproj:29229 > > + 41B28AEA1F828F6B00FB52AC /* LibWebRTCProviderCocoa.h in Headers */, > > Is this part of the patch?
Clearly not!
WebKit Commit Bot
Comment 6
2017-10-03 11:09:59 PDT
Comment on
attachment 322531
[details]
Patch for landing Clearing flags on attachment: 322531 Committed
r222789
: <
http://trac.webkit.org/changeset/222789
>
WebKit Commit Bot
Comment 7
2017-10-03 11:10:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8
2017-10-03 11:11:19 PDT
<
rdar://problem/34794268
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug