Bug 177756 - Remove no longer needed WebRTC build infrastructure
Summary: Remove no longer needed WebRTC build infrastructure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-02 10:54 PDT by youenn fablet
Modified: 2017-10-03 11:11 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.99 MB, patch)
2017-10-02 10:57 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (1.99 MB, patch)
2017-10-02 14:28 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (1.99 MB, patch)
2017-10-03 09:16 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-10-02 10:54:02 PDT
Some files are no longer needed
Comment 1 youenn fablet 2017-10-02 10:57:33 PDT
Created attachment 322392 [details]
Patch
Comment 2 youenn fablet 2017-10-02 14:28:35 PDT
Created attachment 322437 [details]
Patch
Comment 3 Alejandro G. Castro 2017-10-03 02:56:47 PDT
Comment on attachment 322437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322437&action=review

LGTM, with the small comment.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:29229
> +				41B28AEA1F828F6B00FB52AC /* LibWebRTCProviderCocoa.h in Headers */,

Is this part of the patch?

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:33316
> +				41B28AE91F828F6800FB52AC /* LibWebRTCProviderCocoa.cpp in Sources */,

Ditto.
Comment 4 youenn fablet 2017-10-03 09:16:13 PDT
Created attachment 322531 [details]
Patch for landing
Comment 5 youenn fablet 2017-10-03 09:17:08 PDT
Thanks for the review.

(In reply to Alejandro G. Castro from comment #3)
> Comment on attachment 322437 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=322437&action=review
> 
> LGTM, with the small comment.
> 
> > Source/WebCore/WebCore.xcodeproj/project.pbxproj:29229
> > +				41B28AEA1F828F6B00FB52AC /* LibWebRTCProviderCocoa.h in Headers */,
> 
> Is this part of the patch?

Clearly not!
Comment 6 WebKit Commit Bot 2017-10-03 11:09:59 PDT
Comment on attachment 322531 [details]
Patch for landing

Clearing flags on attachment: 322531

Committed r222789: <http://trac.webkit.org/changeset/222789>
Comment 7 WebKit Commit Bot 2017-10-03 11:10:01 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-10-03 11:11:19 PDT
<rdar://problem/34794268>