Bug 177408 - Remove SetterMayThrowException
Summary: Remove SetterMayThrowException
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-23 10:51 PDT by youenn fablet
Modified: 2017-09-27 12:20 PDT (History)
4 users (show)

See Also:


Attachments
Patch (131.84 KB, patch)
2017-09-23 10:57 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-09-23 10:51:28 PDT
It is no longer needed.
Might also change a little bit AttributeSetter to not make it a template class anymore, since this is somehow redundant with the Functor parameter of its call method.
Comment 1 youenn fablet 2017-09-23 10:57:36 PDT
Created attachment 321634 [details]
Patch
Comment 2 Build Bot 2017-09-23 10:59:54 PDT
Attachment 321634 [details] did not pass style-queue:


ERROR: Source/WebCore/bindings/js/JSDOMAttribute.h:96:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 65 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2017-09-23 19:38:11 PDT
Comment on attachment 321634 [details]
Patch

Clearing flags on attachment: 321634

Committed r222429: <http://trac.webkit.org/changeset/222429>
Comment 4 WebKit Commit Bot 2017-09-23 19:38:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:20:49 PDT
<rdar://problem/34693096>