Bug 176745 - Fix multiple master.cfg unit test failures
Summary: Fix multiple master.cfg unit test failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-09-11 15:10 PDT by Ryan Haddad
Modified: 2017-09-27 12:31 PDT (History)
6 users (show)

See Also:

Attachments
Patch (7.31 KB, patch)
2017-09-11 15:17 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-09-11 15:10:02 PDT 
A few master.cfg unit test failures have accumulated. We should fix them.
Comment 1 Ryan Haddad 2017-09-11 15:11:40 PDT 
The failures were introduced with:
https://trac.webkit.org/changeset/221737/webkit
https://trac.webkit.org/changeset/220238/webkit
Comment 2 Ryan Haddad 2017-09-11 15:17:56 PDT 
Created attachment 320484 [details]
Patch
Comment 3 Build Bot 2017-09-11 15:19:12 PDT 
Attachment 320484 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:407:  whitespace before ':'  [pep8/E203] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 WebKit Commit Bot 2017-09-11 15:43:33 PDT 
Comment on attachment 320484 [details]
Patch

Clearing flags on attachment: 320484

Committed r221886: <http://trac.webkit.org/changeset/221886>
Comment 5 WebKit Commit Bot 2017-09-11 15:43:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:31:11 PDT 
<rdar://problem/34693417>