Bug 176676 - WSL should be able to handle a simple constexpr type parameter
Summary: WSL should be able to handle a simple constexpr type parameter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency tree / graph
 
Reported: 2017-09-10 15:31 PDT by Filip Pizlo
Modified: 2018-10-13 16:51 PDT (History)
6 users (show)

See Also:

Attachments
the patch (14.41 KB, patch)
2017-09-10 15:41 PDT, Filip Pizlo 		mmaxfield: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-09-10 15:31:36 PDT 
Patch forthcoming.
Comment 1 Filip Pizlo 2017-09-10 15:41:16 PDT 
Created attachment 320404 [details]
the patch
Comment 2 Build Bot 2017-09-10 15:43:44 PDT 
Attachment 320404 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Myles C. Maxfield 2017-09-11 08:34:47 PDT 
Comment on attachment 320404 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320404&action=review

This is great; this is one of the things I wanted to do this week. Thanks!

> Tools/ChangeLog:5
> +

OOPS 😬
Comment 4 Filip Pizlo 2017-09-11 10:18:56 PDT 
Landed in https://trac.webkit.org/changeset/221859/webkit
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:33:28 PDT 
<rdar://problem/34693480>
Comment 6 Myles C. Maxfield 2018-10-13 16:51:45 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/144