[GStreamer] Missing GRefPtr adoptions in MediaPlayerPrivateGStreamerBase, PlaybackPipeline
Created attachment 320340 [details] Patch
Comment on attachment 320340 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320340&action=review > Source/WebCore/platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:464 > + GRefPtr<GstPad> srcPad = adoptGRef(sinkPad ? gst_pad_get_peer(sinkPad.get()) : nullptr); adoptGref(nullptr) looks weird, I would write this as: GRefPtr<GstPad> srcPad = sinkPad ? adoptGRef(gst_pad_get_peer(sinkPad.get())) : nullptr;
Committed r221815: <http://trac.webkit.org/changeset/221815>
<rdar://problem/34694520>