Bug 176553 - WSL should check recursion
Summary: WSL should check recursion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 176199
  Show dependency tree / graph
 
Reported: 2017-09-07 12:28 PDT by Filip Pizlo
Modified: 2018-10-13 16:56 PDT (History)
3 users (show)

See Also:

Attachments
the patch (7.47 KB, patch)
2017-09-07 12:30 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (7.42 KB, patch)
2017-09-07 12:31 PDT, Filip Pizlo 		msaboff: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-09-07 12:28:57 PDT 
It currently only checks it in Inliner, which is wrong for generic functions that we happen to not call.  Patch forthcoming.
Comment 1 Filip Pizlo 2017-09-07 12:30:07 PDT 
Created attachment 320157 [details]
the patch
Comment 2 Filip Pizlo 2017-09-07 12:31:15 PDT 
Created attachment 320158 [details]
the patch
Comment 3 Michael Saboff 2017-09-07 12:50:51 PDT 
Comment on attachment 320158 [details]
the patch

r=me
Comment 4 Mark Lam 2017-09-07 12:51:06 PDT 
Comment on attachment 320158 [details]
the patch

r=me too.
Comment 5 Filip Pizlo 2017-09-07 12:56:24 PDT 
Landed in https://trac.webkit.org/changeset/221750/webkit
Comment 6 Radar WebKit Bug Importer 2017-09-27 12:34:52 PDT 
<rdar://problem/34693528>
Comment 7 Myles C. Maxfield 2018-10-13 16:56:00 PDT 
Migrated to https://github.com/gpuweb/WHLSL/issues/148