Bug 176541 – [Win] tests/security/contentSecurityPolicy/report-only.php is flaky.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Per Arne Vollan]

From the httpd error log:

[Thu Sep 07 01:50:11.131370 2017] [:error] [pid 4576:tid 824] [client 127.0.0.1:61925] PHP Warning:  rename(C:\\Users\\buildbot\\AppData\\Local\\Temp/-security-contentSecurityPolicy-report-only.php.csp-report.txt.tmp,C:\\Users\\buildbot\\AppData\\Local\\Temp/-security-contentSecurityPolicy-report-only.php.csp-report.txt): The process cannot access the file because it is being used by another process. (code: 32) in C:\\cygwin\\home\\buildbot\\slave\\win-release-tests\\build\\LayoutTests\\http\\tests\\security\\contentSecurityPolicy\\resources\\save-report.php on line 24, referer: http://127.0.0.1:8000/security/contentSecurityPolicy/report-only.php

[Per Arne Vollan]

Created attachment 320154 [details]
Patch

[Per Arne Vollan]

This is not the most elegant solution, maybe there are better approaches?

[Brent Fulgham]

Comment on attachment 320154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=320154&action=review

This isn't very elegant, but it's worth a try to get the Windows tests to work consistently.

> LayoutTests/http/tests/security/contentSecurityPolicy/resources/save-report.php:27
> +    sleep(1);

Is there a way we could do the loop for Windows only? We don't seem to need it on other platforms.

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #3)
> Comment on attachment 320154 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=320154&action=review
> 
> This isn't very elegant, but it's worth a try to get the Windows tests to
> work consistently.
> 
> > LayoutTests/http/tests/security/contentSecurityPolicy/resources/save-report.php:27
> > +    sleep(1);
> 
> Is there a way we could do the loop for Windows only? We don't seem to need
> it on other platforms.

I think we possibly can add a platform check?

Thanks for reviewing!

[WebKit Commit Bot]

Comment on attachment 320154 [details]
Patch

Clearing flags on attachment: 320154

Committed r221752: <http://trac.webkit.org/changeset/221752>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34694536>