Bug 176206 - Graph::methodOfGettingAValueProfileFor compares NodeOrigin instead of the semantic CodeOrigin
Summary: Graph::methodOfGettingAValueProfileFor compares NodeOrigin instead of the sem...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-31 18:31 PDT by Saam Barati
Modified: 2017-09-27 12:48 PDT (History)
13 users (show)

See Also:

Attachments
patch (3.71 KB, patch)
2017-08-31 18:48 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2017-08-31 18:31:56 PDT 
This is a followup to:
https://bugs.webkit.org/show_bug.cgi?id=164600

That patch says we should only write to the result bits of the ArithProfile of the operand when it's not generated from the same byte code as the current node. However, it's comparing NodeOrigin, not NodeOrigin::semantic.
Comment 1 Saam Barati 2017-08-31 18:48:35 PDT 
Created attachment 319562 [details]
patch
Comment 2 Keith Miller 2017-08-31 18:50:21 PDT 
Comment on attachment 319562 [details]
patch

r=me.
Comment 3 WebKit Commit Bot 2017-08-31 20:05:42 PDT 
Comment on attachment 319562 [details]
patch

Clearing flags on attachment: 319562

Committed r221470: <http://trac.webkit.org/changeset/221470>
Comment 4 WebKit Commit Bot 2017-08-31 20:05:44 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-09-27 12:48:15 PDT 
<rdar://problem/34694054>