176175 – [Mac] Upstream AppKit-related WebKitSystemInterface functions

RESOLVED FIXED 176175

[Mac] Upstream AppKit-related WebKitSystemInterface functions

https://bugs.webkit.org/show_bug.cgi?id=176175

Summary [Mac] Upstream AppKit-related WebKitSystemInterface functions

Andy Estes

Reported 2017-08-31 12:22:38 PDT

[Mac] Upstream AppKit-related WebKitSystemInterface functions

Attachments
Patch (37.61 KB, patch) 2017-08-31 12:25 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (37.64 KB, patch) 2017-08-31 12:28 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (37.63 KB, patch) 2017-08-31 12:48 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (37.61 KB, patch) 2017-08-31 17:02 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (37.94 KB, patch) 2017-08-31 17:24 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (37.95 KB, patch) 2017-08-31 17:35 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (38.01 KB, patch) 2017-08-31 20:43 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Patch (38.58 KB, patch) 2017-08-31 21:37 PDT, Andy Estes	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Andy Estes

Comment 1 2017-08-31 12:25:19 PDT Comment hidden (obsolete)

Created attachment 319496 [details] Patch

Build Bot

Comment 2 2017-08-31 12:27:02 PDT Comment hidden (obsolete)

Attachment 319496 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:463: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 3 2017-08-31 12:28:04 PDT Comment hidden (obsolete)

Created attachment 319498 [details] Patch

Build Bot

Comment 4 2017-08-31 12:30:53 PDT Comment hidden (obsolete)

Attachment 319498 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:463: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 5 2017-08-31 12:48:05 PDT Comment hidden (obsolete)

Created attachment 319505 [details] Patch

Build Bot

Comment 6 2017-08-31 12:49:54 PDT Comment hidden (obsolete)

Attachment 319505 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:463: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 7 2017-08-31 17:02:32 PDT Comment hidden (obsolete)

Created attachment 319542 [details] Patch

Build Bot

Comment 8 2017-08-31 17:03:56 PDT Comment hidden (obsolete)

Attachment 319542 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:463: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 9 2017-08-31 17:24:21 PDT Comment hidden (obsolete)

Created attachment 319548 [details] Patch

Build Bot

Comment 10 2017-08-31 17:25:59 PDT Comment hidden (obsolete)

Attachment 319548 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:463: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 11 2017-08-31 17:35:06 PDT Comment hidden (obsolete)

Created attachment 319553 [details] Patch

Build Bot

Comment 12 2017-08-31 17:36:49 PDT Comment hidden (obsolete)

Attachment 319553 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:463: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 13 2017-08-31 20:43:30 PDT Comment hidden (obsolete)

Created attachment 319568 [details] Patch

Build Bot

Comment 14 2017-08-31 20:45:17 PDT Comment hidden (obsolete)

Attachment 319568 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:463: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.

Andy Estes

Comment 15 2017-08-31 21:37:27 PDT Comment hidden (obsolete)

Created attachment 319573 [details] Patch

Build Bot

Comment 16 2017-08-31 21:38:40 PDT Comment hidden (obsolete)

Attachment 319573 [details] did not pass style-queue: ERROR: Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginInstanceProxy.mm:463: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 17 2017-08-31 23:00:37 PDT

Comment on attachment 319573 [details] Patch Clearing flags on attachment: 319573 Committed r221473: <http://trac.webkit.org/changeset/221473>

WebKit Commit Bot

Comment 18 2017-08-31 23:00:39 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 19 2017-09-27 12:44:37 PDT

<rdar://problem/34693869>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Andy Estes

Reported

2017-08-31 12:22 PDT

Modified

2017-09-27 12:44 PDT History

CC List

10 users Show

URL

Keywords InRadar

Depends on

Blocks