Bug 176149 - Crash in WebCore::WebSocketChannel::fail
Summary: Crash in WebCore::WebSocketChannel::fail
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-30 21:35 PDT by Michael Catanzaro
Modified: 2017-08-31 09:57 PDT (History)
1 user (show)

See Also:

Attachments
Backtrace (94.62 KB, text/plain)
2017-08-30 21:35 PDT, Michael Catanzaro 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2017-08-30 21:35:29 PDT 
Created attachment 319444 [details]
Backtrace

Crash in WebCore::WebSocketChannel::fail:

Truncated backtrace:
Thread no. 1 (10 frames)
 #0 WebCore::WebSocketChannel::fail at /usr/src/debug/webkitgtk-2.16.3/Source/WebCore/Modules/websockets/WebSocketChannel.cpp:238
 #1 WebCore::WebSocketChannel::didOpenSocketStream at /usr/src/debug/webkitgtk-2.16.3/Source/WebCore/Modules/websockets/WebSocketChannel.cpp:282
 #2 WebCore::SocketStreamHandleImpl::connectedCallback at /usr/src/debug/webkitgtk-2.16.3/Source/WebCore/platform/network/soup/SocketStreamHandleImplSoup.cpp:137
 #3 g_task_return_now at gtask.c:1121
 #4 g_task_return at gtask.c:1179
 #5 g_socket_client_async_connect_complete at gsocketclient.c:1369
 #6 g_task_return_now at gtask.c:1121
 #7 g_task_return at gtask.c:1179
 #8 handshake_thread_completed at gtlsconnection-gnutls.c:1431
 #9 g_task_return_now at gtask.c:1121

Better backtrace attached. I have only two reports of this crash, so it's probably low-priority, but I bet it would be safe to just null check m_client in WebSocketChannel::fail.
Comment 1 Alexey Proskuryakov 2017-08-31 09:57:46 PDT 
Cf. rdar://problem/21812252. It seems worth spending effort on a regression test, the coverage is not great.