Bug 175993 - Land stubs for File and Directory Entries API interfaces
Summary: Land stubs for File and Directory Entries API interfaces
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 175976
  Show dependency treegraph
 
Reported: 2017-08-25 13:19 PDT by Chris Dumez
Modified: 2017-08-25 15:41 PDT (History)
9 users (show)

See Also:


Attachments
Patch (85.95 KB, patch)
2017-08-25 13:51 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (85.88 KB, patch)
2017-08-25 14:58 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-08-25 13:19:01 PDT
Land stubs for File and Directory Entries API interfaces:
- https://wicg.github.io/entries-api/#idl-index
Comment 1 Radar WebKit Bug Importer 2017-08-25 13:19:35 PDT
<rdar://problem/34087477>
Comment 2 Chris Dumez 2017-08-25 13:51:56 PDT
Created attachment 319097 [details]
Patch
Comment 3 Build Bot 2017-08-25 13:53:06 PDT
Attachment 319097 [details] did not pass style-queue:


ERROR: Source/WebCore/CMakeLists.txt:156:  Alphabetical sorting problem. "Modules/entriesapi" should be before "Modules/encryptedmedia/legacy".  [list/order] [5]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Ryosuke Niwa 2017-08-25 14:55:05 PDT
Comment on attachment 319097 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319097&action=review

> Source/WebCore/Modules/entriesapi/FileSystemDirectoryEntry.idl:34
> +                 optional FileSystemFlags options,
> +                 optional FileSystemEntryCallback? successCallback,
> +                 optional ErrorCallback? errorCallback);

Can we use WebKit style indentation (4 spaces to the right of avoid getFile) instead?

> Source/WebCore/Modules/entriesapi/FileSystemDirectoryEntry.idl:39
> +                      optional FileSystemFlags options,
> +                      optional FileSystemEntryCallback? successCallback,
> +                      optional ErrorCallback? errorCallback);

Ditto.
Comment 5 Chris Dumez 2017-08-25 14:58:40 PDT
Created attachment 319103 [details]
Patch
Comment 6 Build Bot 2017-08-25 15:00:25 PDT
Attachment 319103 [details] did not pass style-queue:


ERROR: Source/WebCore/CMakeLists.txt:156:  Alphabetical sorting problem. "Modules/entriesapi" should be before "Modules/encryptedmedia/legacy".  [list/order] [5]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2017-08-25 15:41:08 PDT
Comment on attachment 319103 [details]
Patch

Clearing flags on attachment: 319103

Committed r221209: <http://trac.webkit.org/changeset/221209>
Comment 8 WebKit Commit Bot 2017-08-25 15:41:10 PDT
All reviewed patches have been landed.  Closing bug.