Bug 175531 - [GTK][WPE] Avoid emitting WebKitFaviconDatabase::favicon-changed multiple times while setting an icon
Summary: [GTK][WPE] Avoid emitting WebKitFaviconDatabase::favicon-changed multiple tim...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-08-14 04:55 PDT by Carlos Garcia Campos
Modified: 2017-08-14 08:44 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.24 KB, patch)
2017-08-14 05:00 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-08-14 04:55:52 PDT 
When webkitFaviconDatabaseSetIconForPageURL() is called, both setIconURLForPageURL() and setIconDataForIconURL() might notify the client, which ends up emitting the WebKitFaviconDatabase::favicon-changed signal and calling webkitFaviconDatabaseSetIconURLForPageURL(). Both things are already done by webkitFaviconDatabaseSetIconForPageURL() itself, so we can just ignore the client notification while setting a new icon.
Comment 1 Carlos Garcia Campos 2017-08-14 05:00:14 PDT 
Created attachment 318031 [details]
Patch
Comment 2 Build Bot 2017-08-14 05:01:24 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2017-08-14 08:44:11 PDT 
Committed r220694: <http://trac.webkit.org/changeset/220694>