RESOLVED FIXED 175531
[GTK][WPE] Avoid emitting WebKitFaviconDatabase::favicon-changed multiple times while setting an icon 
https://bugs.webkit.org/show_bug.cgi?id=175531
Summary [GTK][WPE] Avoid emitting WebKitFaviconDatabase::favicon-changed multiple tim...
Carlos Garcia Campos
Reported 2017-08-14 04:55:52 PDT
When webkitFaviconDatabaseSetIconForPageURL() is called, both setIconURLForPageURL() and setIconDataForIconURL() might notify the client, which ends up emitting the WebKitFaviconDatabase::favicon-changed signal and calling webkitFaviconDatabaseSetIconURLForPageURL(). Both things are already done by webkitFaviconDatabaseSetIconForPageURL() itself, so we can just ignore the client notification while setting a new icon.
Attachments
Patch (3.24 KB, patch)
2017-08-14 05:00 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-08-14 05:00:14 PDT
Created attachment 318031 [details] Patch
Build Bot
Comment 2 2017-08-14 05:01:24 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Garcia Campos
Comment 3 2017-08-14 08:44:11 PDT
Committed r220694: <http://trac.webkit.org/changeset/220694>
Note You need to log in before you can comment on or make changes to this bug.