Bug 175456 - [PAL] Move Sleep classes into PAL
Summary: [PAL] Move Sleep classes into PAL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-10 16:11 PDT by Don Olmstead
Modified: 2017-08-15 14:09 PDT (History)
6 users (show)

See Also:


Attachments
Patch (42.32 KB, patch)
2017-08-15 10:42 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch (42.19 KB, patch)
2017-08-15 11:34 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-08-10 16:11:02 PDT
Move SleepDisabler and SystemSleepListener into PAL.
Comment 1 Don Olmstead 2017-08-15 10:42:46 PDT
Created attachment 318136 [details]
Patch
Comment 2 Build Bot 2017-08-15 10:44:46 PDT
Attachment 318136 [details] did not pass style-queue:


ERROR: Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm:38:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Don Olmstead 2017-08-15 11:34:17 PDT
Created attachment 318140 [details]
Patch

Fixing style
Comment 4 Ryosuke Niwa 2017-08-15 13:37:22 PDT
Comment on attachment 318140 [details]
Patch

Looks sane to me.
Comment 5 WebKit Commit Bot 2017-08-15 14:08:25 PDT
Comment on attachment 318140 [details]
Patch

Clearing flags on attachment: 318140

Committed r220759: <http://trac.webkit.org/changeset/220759>
Comment 6 WebKit Commit Bot 2017-08-15 14:08:26 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-15 14:09:48 PDT
<rdar://problem/33903579>