174871 – Rename {Web/UI}Process/Storage to {Web/UI}Process/WebStorage

RESOLVED FIXED Bug 174871

Rename {Web/UI}Process/Storage to {Web/UI}Process/WebStorage

https://bugs.webkit.org/show_bug.cgi?id=174871

Summary Rename {Web/UI}Process/Storage to {Web/UI}Process/WebStorage

Brady Eidson

Reported 2017-07-26 13:33:15 PDT

Rename {Web/UI}Process/Storage to {Web/UI}Process/WebStorage The standard this directories help implement is the "WebStorage" standard, and "Storage" is too general of a concept that we'll want to start using in other contexts soon.

Attachments
Patch (309.71 KB, patch) 2017-07-26 13:45 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (309.96 KB, patch) 2017-07-26 13:56 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (311.68 KB, patch) 2017-07-26 14:12 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Patch (312.32 KB, patch) 2017-07-26 14:36 PDT, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2017-07-26 13:45:15 PDT

Created attachment 316472 [details] Patch

Build Bot

Comment 2 2017-07-26 13:48:23 PDT

Attachment 316472 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebStorage/StorageAreaMap.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebStorage/WebStorageNamespaceProvider.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/UIProcess/WebStorage/LocalStorageDatabase.cpp:252: 'localStorageDatabase' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/UIProcess/WebStorage/StorageManager.cpp:597: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 3 2017-07-26 13:56:40 PDT

Created attachment 316474 [details] Patch

Build Bot

Comment 4 2017-07-26 14:00:35 PDT

Attachment 316474 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebStorage/StorageAreaMap.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebStorage/WebStorageNamespaceProvider.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/UIProcess/WebStorage/LocalStorageDatabase.cpp:252: 'localStorageDatabase' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/UIProcess/WebStorage/StorageManager.cpp:597: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 5 2017-07-26 14:12:20 PDT

Created attachment 316478 [details] Patch

Build Bot

Comment 6 2017-07-26 14:15:15 PDT

Attachment 316478 [details] did not pass style-queue: ERROR: Source/WebKit/WebProcess/WebStorage/StorageAreaMap.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebStorage/WebStorageNamespaceProvider.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/WebProcess/WebStorage/StorageAreaImpl.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebKit/UIProcess/WebStorage/LocalStorageDatabase.cpp:252: 'localStorageDatabase' is incorrectly named. It should be named 'protectedThis'. [readability/naming/protected] [4] ERROR: Source/WebKit/UIProcess/WebStorage/StorageManager.cpp:597: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.

Brady Eidson

Comment 7 2017-07-26 14:36:35 PDT

Created attachment 316482 [details] Patch

Build Bot

Comment 8 2017-07-26 14:40:29 PDT

Attachment 316482 [details] did not pass style-queue: ERROR: Source/WebKit/UIProcess/WebStorage/StorageManager.cpp:597: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 9 2017-07-26 15:52:44 PDT

Comment on attachment 316482 [details] Patch Clearing flags on attachment: 316482 Committed r219966: <http://trac.webkit.org/changeset/219966>

WebKit Commit Bot

Comment 10 2017-07-26 15:52:45 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component WebKit2

Assignee

Brady Eidson

Reported

2017-07-26 13:33 PDT

Modified

2017-07-26 15:52 PDT History

CC List

3 users Show

URL

Keywords

Depends on

Blocks