RESOLVED FIXED 174745
More NeverDestroyed and related cleanup 
https://bugs.webkit.org/show_bug.cgi?id=174745
Summary More NeverDestroyed and related cleanup
Darin Adler
Reported 2017-07-21 21:09:13 PDT Comment hidden (obsolete)
Attachments
Patch (99.24 KB, patch)
2017-07-21 21:09 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (108.77 KB, patch)
2017-07-22 10:06 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (108.91 KB, patch)
2017-07-22 10:42 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (109.21 KB, patch)
2017-07-23 13:20 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (113.94 KB, patch)
2017-07-23 14:57 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (114.98 KB, patch)
2017-07-24 09:10 PDT, Darin Adler 		achristensen: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2017-07-21 21:09:39 PDT Comment hidden (obsolete)
Darin Adler
Comment 2 2017-07-22 10:06:47 PDT Comment hidden (obsolete)
Darin Adler
Comment 3 2017-07-22 10:42:37 PDT Comment hidden (obsolete)
Darin Adler
Comment 4 2017-07-23 13:20:51 PDT Comment hidden (obsolete)
Darin Adler
Comment 5 2017-07-23 14:57:32 PDT
Created attachment 316240 [details] Patch
Darin Adler
Comment 6 2017-07-24 09:10:31 PDT
Created attachment 316293 [details] Patch
Alex Christensen
Comment 7 2017-07-24 11:43:20 PDT
Comment on attachment 316293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316293&action=review > Source/WebCore/platform/mac/ThemeMac.mm:736 > case SquareButtonPart: This indentation should also be updated.
Darin Adler
Comment 8 2017-07-24 15:49:14 PDT
Comment on attachment 316293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316293&action=review >> Source/WebCore/platform/mac/ThemeMac.mm:736 >> case SquareButtonPart: > > This indentation should also be updated. Thanks for spotting that! I will fix before landing.
Darin Adler
Comment 9 2017-07-24 15:53:27 PDT
Comment on attachment 316293 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316293&action=review > Source/WebCore/platform/mac/ThemeMac.mm:751 > + // by definition constrained, since we select mini only for small cramped environments. I should also add a closing parenthesis here.
Darin Adler
Comment 10 2017-07-24 21:29:14 PDT
Committed r219858: <http://trac.webkit.org/changeset/219858>
Note You need to log in before you can comment on or make changes to this bug.