Bug 174589 - Web Inspector: adjust wording of "clear when page {navigates -> loads}"
Summary: Web Inspector: adjust wording of "clear when page {navigates -> loads}"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-17 10:49 PDT by BJ Burg
Modified: 2017-07-18 15:28 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.26 KB, patch)
2017-07-17 10:50 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (956.98 KB, application/zip)
2017-07-17 12:19 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-07-17 10:49:00 PDT 
In some locales it isn't natural to consider a reload as a kind of navigation, so just say when "page loads".
Comment 1 BJ Burg 2017-07-17 10:49:20 PDT 
<rdar://problem/32797981>
Comment 2 BJ Burg 2017-07-17 10:50:06 PDT 
Created attachment 315676 [details]
Patch
Comment 3 Build Bot 2017-07-17 12:19:52 PDT 
Comment on attachment 315676 [details]
Patch

Attachment 315676 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4136751

New failing tests:
http/tests/canvas/canvas-tainted-after-draw-image.html
Comment 4 Build Bot 2017-07-17 12:19:54 PDT 
Created attachment 315691 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 5 Joseph Pecoraro 2017-07-18 14:54:21 PDT 
Comment on attachment 315676 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2017-07-18 15:28:36 PDT 
Comment on attachment 315676 [details]
Patch

Clearing flags on attachment: 315676

Committed r219635: <http://trac.webkit.org/changeset/219635>
Comment 7 WebKit Commit Bot 2017-07-18 15:28:38 PDT 
All reviewed patches have been landed.  Closing bug.