Bug 174372 - WebDragClient build broken when !PLATFORM(COCOA) && !PLATFORM(GTK)
Summary: WebDragClient build broken when !PLATFORM(COCOA) && !PLATFORM(GTK)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Other Linux
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-11 10:42 PDT by Timothy Hatcher
Modified: 2017-07-11 13:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.34 KB, patch)
2017-07-11 10:44 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (964.83 KB, application/zip)
2017-07-11 12:51 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2017-07-11 10:42:44 PDT 
The didConcludeEditDrag() method is missing for other platforms. Patch to follow.
Comment 1 Timothy Hatcher 2017-07-11 10:44:07 PDT 
Created attachment 315130 [details]
Patch
Comment 2 Build Bot 2017-07-11 12:51:37 PDT 
Comment on attachment 315130 [details]
Patch

Attachment 315130 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4102147

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
Comment 3 Build Bot 2017-07-11 12:51:38 PDT 
Created attachment 315146 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 4 Timothy Hatcher 2017-07-11 12:52:33 PDT 
Test failures unrelated.
Comment 5 WebKit Commit Bot 2017-07-11 13:38:14 PDT 
Comment on attachment 315130 [details]
Patch

Clearing flags on attachment: 315130

Committed r219357: <http://trac.webkit.org/changeset/219357>
Comment 6 WebKit Commit Bot 2017-07-11 13:38:16 PDT 
All reviewed patches have been landed.  Closing bug.