Bug 174109 - Receiving tracks should be ended when peer connection is being closed
Summary: Receiving tracks should be ended when peer connection is being closed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-03 16:14 PDT by youenn fablet
Modified: 2017-07-05 08:53 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.85 KB, patch)
2017-07-03 16:32 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (6.72 KB, patch)
2017-07-05 08:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-07-03 16:14:55 PDT 
Receiving tracks should be ended when peer connection is being closed as per the spec.
Comment 1 youenn fablet 2017-07-03 16:32:53 PDT 
Created attachment 314535 [details]
Patch
Comment 2 Eric Carlson 2017-07-05 07:27:26 PDT 
Comment on attachment 314535 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314535&action=review

> LayoutTests/webrtc/peer-connection-track-end.html:40
> +            setTimeout(() => { reject("onended callbacks too long"); }, 5000);

Nit: "callbacks too long" => "callbacks took too long"
Comment 3 youenn fablet 2017-07-05 08:15:48 PDT 
Created attachment 314604 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2017-07-05 08:53:20 PDT 
Comment on attachment 314604 [details]
Patch for landing

Clearing flags on attachment: 314604

Committed r219127: <http://trac.webkit.org/changeset/219127>
Comment 5 WebKit Commit Bot 2017-07-05 08:53:21 PDT 
All reviewed patches have been landed.  Closing bug.