RESOLVED FIXED 174067
[macOS] Remove code only needed when building for OS X Yosemite 
https://bugs.webkit.org/show_bug.cgi?id=174067
Summary [macOS] Remove code only needed when building for OS X Yosemite
mitz
Reported 2017-07-01 09:22:43 PDT
The Yosemite build was broken a while ago but some code remains in the source tree that is only needed when building for Yosemite.
Attachments
Remove unneeded code (177.81 KB, patch)
2017-07-01 11:08 PDT, mitz 		thorton: review+
DetailsFormatted DiffDiff
Remove unneeded code (181.59 KB, patch)
2017-07-01 12:03 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Remove unneeded code (182.18 KB, patch)
2017-07-01 13:41 PDT, mitz 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2017-07-01 11:08:56 PDT
Created attachment 314388 [details] Remove unneeded code
Build Bot
Comment 2 2017-07-01 11:11:30 PDT
Attachment 314388 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WTF/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebCore/PAL/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/ThirdParty/libwebrtc/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/bmalloc/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 10 in 48 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 3 2017-07-01 12:03:22 PDT
Created attachment 314389 [details] Remove unneeded code Trying to fix the iOS build
Build Bot
Comment 4 2017-07-01 12:06:25 PDT
Attachment 314389 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WTF/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebCore/PAL/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/ThirdParty/libwebrtc/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/bmalloc/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 10 in 49 files If any of these errors are false positives, please file a bug against check-webkit-style.
mitz
Comment 5 2017-07-01 13:41:05 PDT
Created attachment 314390 [details] Remove unneeded code
mitz
Comment 6 2017-07-01 14:12:18 PDT
Committed <https://trac.webkit.org/r219050>.
Note You need to log in before you can comment on or make changes to this bug.